Handle updated activities on StoriesFeedUpdated #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for updating individual activities in addition to aggregated activities when a StoriesFeedUpdated event is received. The StoriesFeedUpdatedEvent network model already contained an activities field, but it was not being processed or passed through the state management system.
Key changes:
- Added
activitiesparameter toStoriesFeedUpdatedstate event andonStoriesFeedUpdatedhandler - Implemented
updateActivitieshelper function to merge activity updates - Updated tests to verify both activities and aggregated activities are properly updated
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| StateUpdateEvent.kt | Added activities field to StoriesFeedUpdated event and mapped it from the WebSocket event |
| FeedStateImpl.kt | Added updateActivities helper function and updated onStoriesFeedUpdated to process both activities and aggregated activities |
| FeedEventHandler.kt | Updated handler to pass activities parameter when calling onStoriesFeedUpdated |
| FeedEventHandlerTest.kt | Updated test cases to include activities in StoriesFeedUpdated event creation |
| FeedStateImplTest.kt | Enhanced test to verify both activities and aggregated activities are updated correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SDK Size Comparison 📏
|
|
aleksandar-apostolov
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The stories updated event now contain activities in addition to aggregated activities, so we should handle those too as pointed out in #134 (comment).
Implementation
Update activities in the story feed based on the ones that come in the event
Testing
The demo displays aggregated activities, so it's not easy to test it there. One would need to change the demo to show stories from
activitiesinstead.Checklist